jsk_topic_tools: stealth_relay add options as dynamic_reconfigure #1568

furushchev · 2017-10-31T12:46:08Z

This pull request is for updating jsk_topic_tools/StealthRelay nodelet:

Support dynamic reconfigure
Keep consistency with upstream (param name etc..)
Cleanup internal function
Add option enable_monitor to toggle monitoring
update test codes

k-okada · 2017-10-31T15:24:36Z

Can we remove this node if ros/ros_comm#1155 is merged? if so, we will add

ROS_WARN('Will be deprecated when https://github.com/ros/ros_comm/pull/1155 is merged")

furushchev · 2017-10-31T22:45:49Z

@k-okada Added. 👍

k-okada · 2017-11-03T04:28:46Z

https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/296166269#L4767

rostest log file is in /workspace/jsk-ros-pkg/jsk_common/log/rostest-0225cf33e2bf-21373.log
+ '[' 0 '!=' 0 ']'
+ for test_file in '$rostest_files'
+ echo '[jsk_topic_tools] Testing install/share/jsk_topic_tools/test/test_stealth_relay.test'
[jsk_topic_tools] Testing install/share/jsk_topic_tools/test/test_stealth_relay.test
+ rostest install/share/jsk_topic_tools/test/test_stealth_relay.test
Traceback (most recent call last):
  File "/workspace/ros/ws_jsk_common/install/share/jsk_topic_tools/test/test_stealth_relay.py", line 61, in <module>
    rostest.rosrun("jsk_topic_tools", "test_stealth_relay", TestStealthRelay)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/__init__.py", line 146, in rosrun
    result = rosunit.create_xml_runner(package, test_name, result_file).run(suite)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rosunit/xmlrunner.py", line 233, in run
    test(result)
  File "/usr/lib/python2.7/unittest/suite.py", line 70, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/suite.py", line 108, in run
    test(result)
  File "/usr/lib/python2.7/unittest/case.py", line 395, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/workspace/ros/ws_jsk_common/install/share/jsk_topic_tools/test/test_stealth_relay.py", line 51, in test_stealth_relay
    client.update_configuration({'enable_monitor': False, 'monitor_topic': ''})
  File "/opt/ros/indigo/lib/python2.7/dist-packages/dynamic_reconfigure/client.py", line 219, in update_configuration
    msg    = self._set_service(config).config
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/impl/tcpros_service.py", line 435, in __call__
    return self.call(*args, **kwds)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/impl/tcpros_service.py", line 523, in call
    raise rospy.exceptions.ROSInterruptException("node shutdown interrupted service call")
rospy.exceptions.ROSInterruptException: node shutdown interrupted service call
... logging to /workspace/jsk-ros-pkg/jsk_common/log/rostest-0225cf33e2bf-21486.log
[ROSUNIT] Outputting test results to /workspace/.ros/test_results/jsk_topic_tools/rostest-test_test_stealth_relay.xml
testtest_stealth_relay ... ERROR!
ERROR: max time [40.0s] allotted for test [test_stealth_relay] of type [jsk_topic_tools/test_stealth_relay.py]
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/runner.py", line 148, in fn
    self.test_parent.run_test(test)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/rostest_parent.py", line 132, in run_test
    return self.runner.run_test(test)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/roslaunch/launch.py", line 681, in run_test
    (test.time_limit, test.test_name, test.package, test.type))

furushchev · 2017-11-03T07:23:49Z

This test does not hang on my laptop.. Do you have any idea or suggestion? @k-okada

On Fri, Nov 3, 2017, 13:28 Kei Okada ***@***.***> wrote: https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/296166269#L4767 rostest log file is in /workspace/jsk-ros-pkg/jsk_common/log/rostest-0225cf33e2bf-21373.log + '[' 0 '!=' 0 ']' + for test_file in '$rostest_files' + echo '[jsk_topic_tools] Testing install/share/jsk_topic_tools/test/test_stealth_relay.test' [jsk_topic_tools] Testing install/share/jsk_topic_tools/test/test_stealth_relay.test + rostest install/share/jsk_topic_tools/test/test_stealth_relay.test Traceback (most recent call last): File "/workspace/ros/ws_jsk_common/install/share/jsk_topic_tools/test/test_stealth_relay.py", line 61, in <module> rostest.rosrun("jsk_topic_tools", "test_stealth_relay", TestStealthRelay) File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/__init__.py", line 146, in rosrun result = rosunit.create_xml_runner(package, test_name, result_file).run(suite) File "/opt/ros/indigo/lib/python2.7/dist-packages/rosunit/xmlrunner.py", line 233, in run test(result) File "/usr/lib/python2.7/unittest/suite.py", line 70, in __call__ return self.run(*args, **kwds) File "/usr/lib/python2.7/unittest/suite.py", line 108, in run test(result) File "/usr/lib/python2.7/unittest/case.py", line 395, in __call__ return self.run(*args, **kwds) File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/workspace/ros/ws_jsk_common/install/share/jsk_topic_tools/test/test_stealth_relay.py", line 51, in test_stealth_relay client.update_configuration({'enable_monitor': False, 'monitor_topic': ''}) File "/opt/ros/indigo/lib/python2.7/dist-packages/dynamic_reconfigure/client.py", line 219, in update_configuration msg = self._set_service(config).config File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/impl/tcpros_service.py", line 435, in __call__ return self.call(*args, **kwds) File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/impl/tcpros_service.py", line 523, in call raise rospy.exceptions.ROSInterruptException("node shutdown interrupted service call") rospy.exceptions.ROSInterruptException: node shutdown interrupted service call ... logging to /workspace/jsk-ros-pkg/jsk_common/log/rostest-0225cf33e2bf-21486.log [ROSUNIT] Outputting test results to /workspace/.ros/test_results/jsk_topic_tools/rostest-test_test_stealth_relay.xml testtest_stealth_relay ... ERROR! ERROR: max time [40.0s] allotted for test [test_stealth_relay] of type [jsk_topic_tools/test_stealth_relay.py] File "/usr/lib/python2.7/unittest/case.py", line 331, in run testMethod() File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/runner.py", line 148, in fn self.test_parent.run_test(test) File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/rostest_parent.py", line 132, in run_test return self.runner.run_test(test) File "/opt/ros/indigo/lib/python2.7/dist-packages/roslaunch/launch.py", line 681, in run_test (test.time_limit, test.test_name, test.package, test.type)) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1568 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB0B0GPWEHpbjx6yxQzOSVdn9iQ7c7vfks5sypZ-gaJpZM4QMrp8> .

-- -- ⌘ Yuki Furuta

…gure

furushchev · 2017-11-06T09:37:20Z

@k-okada Please review & merge if it's ok for you! 👍

jsk_topic_tools: add options as dynamic_reconfigure

d69fcd0

furushchev changed the title ~~jsk_topic_tools: add options as dynamic_reconfigure~~ jsk_topic_tools: stealth_relay add options as dynamic_reconfigure Oct 31, 2017

furushchev mentioned this pull request Oct 31, 2017

jsk_robot_startup: add LightweightLogger nodelet jsk-ros-pkg/jsk_robot#827

Merged

furushchev added this to the 2.2.6 milestone Oct 31, 2017

jsk_topic_tools: stealth_relay: add deprecation warning

087a2e0

furushchev force-pushed the update-stealth-relay branch from 55881ea to 087a2e0 Compare October 31, 2017 22:47

k-okada and others added 2 commits November 2, 2017 10:34

Merge branch 'master' into update-stealth-relay

7b11e5c

jsk_topic_tools: test_stealth_relay: update timeout

13a6956

furushchev force-pushed the update-stealth-relay branch from 178516e to 13a6956 Compare November 2, 2017 09:10

jsk_topic_tools: test_stealth_relay: disable updating dynamic reconfi…

f51da27

…gure

furushchev requested a review from k-okada November 6, 2017 08:12

k-okada merged commit c449215 into jsk-ros-pkg:master Nov 8, 2017

furushchev deleted the update-stealth-relay branch November 8, 2017 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jsk_topic_tools: stealth_relay add options as dynamic_reconfigure #1568

jsk_topic_tools: stealth_relay add options as dynamic_reconfigure #1568

furushchev commented Oct 31, 2017

k-okada commented Oct 31, 2017

furushchev commented Oct 31, 2017

k-okada commented Nov 3, 2017

furushchev commented Nov 3, 2017 via email

furushchev commented Nov 6, 2017

jsk_topic_tools: stealth_relay add options as dynamic_reconfigure #1568

jsk_topic_tools: stealth_relay add options as dynamic_reconfigure #1568

Conversation

furushchev commented Oct 31, 2017

k-okada commented Oct 31, 2017

furushchev commented Oct 31, 2017

k-okada commented Nov 3, 2017

furushchev commented Nov 3, 2017 via email

furushchev commented Nov 6, 2017