jsk_topic_tools: add option to display diagnostic messages on warning level #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The name |
|
CC: @708yamaguchi |
furushchev
force-pushed
the
warning-diagnostic
branch
from
bdadd69
to
baaf908
Compare
jsk_topic_tools: update doc for jsk_topic_tools nodelet classes
furushchev
force-pushed
the
warning-diagnostic
branch
from
baaf908
to
6c6c6c7
Compare
|
After discussion with active users, I changed to use |
wkentaro
approved these changes
Jun 21, 2018
|
Added to milestone for possible next release |
This was referenced Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
~use_warningparameter to display diagnostic messages on warning level instead of error level onDiagnosticNodelet.