[jsk_data] add bagfile_prefix arg for record.launch #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirmed bag file is successfully created on PR1012 real robot. using |
|
@furushchev ask someone for review |
|
@mmurooka @wkentaro @chiwunau please review for hrp2, baxter, pr2. 2016年8月12日金曜日、Kei Okadanotifications@github.comさんは書きました:
⌘ Yuki Furuta |
| @@ -11,7 +11,8 @@ | |||
| <arg name="save_multisense" default="false" /> | |||
| <arg name="camera_namespace" default="openni"/> | |||
|
|
|||
| <arg name="save_dir" default="$(env HOME)/.ros"/> | |||
| <arg name="save_dir"/> <!-- destination directory of bagfile --> | |||
There was a problem hiding this comment.
By default rosbag record records bag file on cwd.
This argument implicitly sets save destination to $HOME/.ros, and this can be dangerous for machine which has limited space.
(e.g. PR2 has external HDD for recording bag files, but $HOME which is mounted as system HDD has only 1~10GB and this is shared with system region, so it may occurs failure of booting next time.
Anyway it's better to be another PR for this part. So I reverted this time.
|
For HRP2 specific part, no problem except for #1437 (comment). |
furushchev
force-pushed
the
bagfile-prefix
branch
from
3dc73e8
to
b8dfff1
Compare
|
This might be difficult problem, increasing depends might be not welcomed
◉ Kei Okada On Sun, Aug 14, 2016 at 9:59 AM, Furushchev notifications@github.com
|
|
Sorry for being very late, I tested on my account in PR2 and everything looks good . |
|
@chiwunau thanks! |
|
@k-okada +1 for adding deps especially for this package. Another possible solution is setup testing environment on which dependencies are already installed without rosdep and test by manually launching |
|
please ask baxter users whether if they want to include baxter for the test ◉ Kei Okada On Tue, Aug 23, 2016 at 4:35 PM, Furushchev notifications@github.com
|
What do you mean? there is no baxter package: https://github.com/furushchev/jsk_common/blob/b8dfff11b81ebb65e51428bb420ce7b5ee54dafe/jsk_data/package.xml |
|
yes, that's why travis test fails -> https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/152131969 |
furushchev
force-pushed
the
bagfile-prefix
branch
from
76fdcbd
to
9859d4f
Compare
|
you need to add pr2_description to the tet_depend, or remove that from your test. |
furushchev
force-pushed
the
bagfile-prefix
branch
from
9859d4f
to
c63a66f
Compare
|
problem of authentication in jenkins? |
|
closed via #1450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bagfile_prefixargument forXXX_record.launchdestination bag file is
$(arg save_dir)/$(arg bagfile_prefix)_YYYY-mm-dd-HH-MM-SS.bagWithout this PR, we can set only directory and prefix is always empty.