[jsk_robot_startup] fix python3 decode error in smach_to_mail #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkmtnt7000
reviewed
Mar 26, 2023
There was a problem hiding this comment.
Thank you very much for debugging.
Although it may not be very relevant to this error, it may be a good idea to write the info and description in the same way like this.
tkmtnt7000@e09738a
|
can you open a pr to update this pr? |
|
Sure. Um.. send pr to jsk-ros-pkg directly?? i have just sent pr to knorth55's branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fix error in
python3+smach_to_mail.py.x['MAIL']isbytesobject, so it should be decoded toutf-8.