Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [jsk_pr2_startup] Remove a slash of the first character for noetic (tf2) in publish_empty_cloud.py #1896

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tkmtnt7000
Copy link
Member

This PR removed slashes from the first character of the topics for noetic tf2 compatibility.

Without this PR, tf is not solved and PR2 does not move with move_base when we use empty_cloud in navigation that PR2 Subway demostration uses.

cc: Thanks to @pazeshun

@tkmtnt7000
Copy link
Member Author

tkmtnt7000 commented Dec 5, 2023

With this PR, we can go inside of the elevator in subway demonstration!

Copy link
Member

@mqcmd196 mqcmd196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the real robot with subway demo. Thanks a lot! LGTM

@k-okada k-okada merged commit 39aa4a3 into jsk-ros-pkg:master Dec 7, 2023
8 checks passed
@tkmtnt7000 tkmtnt7000 deleted the PR-remove-slash-empty-cloud branch December 7, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants