chore: clean up comments #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangkoran
force-pushed
the
clean-up-comments
branch
from
ebc823d
to
25fd06d
Compare
mangkoran
commented
Jan 3, 2024
| @@ -55,5 +55,4 @@ | |||
| #cvpublications(cvdata) | |||
| #cvskills(cvdata) | |||
| #cvreferences(cvdata) | |||
|
|
|||
| #endnote | |||
| #endnote() | |||
There was a problem hiding this comment.
Also I updated endnote to be a "function" to be consistent with other. It might break other's cv if they don't update their cv tho. Let me know if it is acceptable or not.
|
Thank you for the clean-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! It's been a while :D
As I am updating my own cv and would like to create PR for multiple position in a company, I found there are several comments that could be removed as I thought the code is "readable" enough by itself.
Let me know if you have any thoughts regarding this. Thanks!