Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect date parsing causing incorrect regrinfo #49

Closed
Mark-H opened this issue Jan 3, 2020 · 1 comment · Fixed by #54
Closed

Incorrect date parsing causing incorrect regrinfo #49

Mark-H opened this issue Jan 3, 2020 · 1 comment · Fixed by #54

Comments

@Mark-H
Copy link

Mark-H commented Jan 3, 2020

Provided a .org domain with the following response (from rawdata) with dates in Y-m-dTH:i:sZ format:

Updated Date: 2019-09-16T15:39:04Z
Creation Date: 2012-10-01T15:32:42Z
Registry Expiry Date: 2020-10-01T15:32:42Z

The parsed information in regrinfo has incorrect dates when Y-m-d could theoretically also be Y-d-m. (e.g. 10-01)

changed: 2019-09-16
created: 2012-01-10
expires: 2020-01-10

Created and expires should be 10-01, changed is fine.

Does not seem to happen exclusively on .org domains.

Somewhat related to #38

Using jsmitty12/phpwhois#5.5.0.

        $whoisTarget = 'proper-full-domain.tld';
        $whois = new Whois();
        $result = $whois->lookup($whoisTarget);
@jsmitty12
Copy link
Owner

example domain exhibiting this problem: scottishrecoveryconsortium.org

jsmitty12 added a commit that referenced this issue May 30, 2020
Improve parsing of dates in standard format
Fixes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants