Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't specify address family, may use the wrong one #61

Closed
nihn opened this issue Mar 19, 2015 · 8 comments
Closed

can't specify address family, may use the wrong one #61

nihn opened this issue Mar 19, 2015 · 8 comments

Comments

@nihn
Copy link

nihn commented Mar 19, 2015

Hi,

latest release come with default ipv6 support. I think it should be an option not set by default because e.g. etsy statsd has ipv6 support disabled by default and updating pystatsd can easily broke metrics collecting and finding cause will be not so obvious (it happened to me :)).
@jsocol
Copy link
Owner

jsocol commented Mar 19, 2015

Interesting point, especially since localhost will usually resolve to ::1 first. Hmm.

The official StatsD server seems to only support one of v4 or v6 at a time. Maybe we need a boolean ipv6 flag, that defaults to False like the server, and then specify the family in the socket.getaddrinfo. Then it's possible that socket.getaddrinfo will raise a socket.gaierror, but that's probably OK.

@jsocol jsocol changed the title 3.1 incompatible with default etsy_statsd configuration. can't specify address family, may use the wrong one Mar 19, 2015
@nihn
Copy link
Author

nihn commented Mar 20, 2015

Hide ipv6 behind the flag seems like a good idea :).

@jsocol
Copy link
Owner

jsocol commented Mar 26, 2015

852c849

@jsocol jsocol closed this as completed Mar 26, 2015
@jzafran
Copy link

jzafran commented Jun 24, 2015

Was this issue ever solved? Commit 852c849 doesn't seem to have anything to do with this.

@jsocol
Copy link
Owner

jsocol commented Jun 24, 2015

You're absolutely right, it was e78b046, which is not on PyPI yet

@jzafran
Copy link

jzafran commented Jun 24, 2015

Thanks @jsocol ! Any timeframe for the release of 3.2 to PyPi?

@jsocol
Copy link
Owner

jsocol commented Jun 24, 2015

I don't really know why I didn't do it in March. Once #63 is wrapped up I'll push the new version.

@jzafran
Copy link

jzafran commented Jun 24, 2015

Sounds good, thanks @jsocol!

csestelo pushed a commit to Destygo/pystatsd that referenced this issue Jul 18, 2022
@maxime-fender
Hexagonal architecture implementation (jsocol#61)
e645adb 
* Create the domain flow, nodes, edges object, and implement flow_execution

* Plug new domain objects to current logic

* Create Answer class in domain, finish implementing test_answer_node_text in domain

* Add first test for buttons

* Upgrade requirements

* raise NotImplmentedError instead of pass

Co-authored-by: Antoine Ogier <antoine.ogier@mindsay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jzafran @jsocol @nihn