Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher issues #20

Closed
Person7557 opened this issue Nov 8, 2023 · 17 comments
Closed

Launcher issues #20

Person7557 opened this issue Nov 8, 2023 · 17 comments

Comments

@Person7557
Copy link

Hello Jsoctocat, my launcher stopped working today after maintenance. I attempted to check files to make sure that its not my bdo folder, game starts fine from official launcher, attempted to update launcher, now i get BrowserForm pop up and display the steps, but it either fails to provide the OTP or simply says wrong OTP/password in the end. Replacing the 1.1.5 version with current 1.1.5 version shows that there is a new launcher version available, but none on the website. Is there one on the way, or is something not working as it should? Thank you.

@Person7557
Copy link
Author

obraz

@jsoctocat
Copy link
Owner

could it be the same as this issue?

#17 (comment)

@Person7557
Copy link
Author

Oh i forgot to mention, i did time sync before writing, as i do remember that from previous issue, but no, it did not resolve the issue for me. Also, is this supposed to show up?

obraz

@Person7557
Copy link
Author

Or any of this?
obraz
obraz

@Person7557
Copy link
Author

Even if i provide the OTP manually, it still shows the following:
obraz

@Person7557
Copy link
Author

I just ran double check on Backup OTP code and seems like its incorrect, I'll restart it and see if it works then.

@jsoctocat
Copy link
Owner

jsoctocat commented Nov 8, 2023

Or any of this? obraz obraz

Yes, these pop-ups are intended because it is possible for a CAPTCHA to appear, and this was the simplest way to address such an issue.

The version check should not pop up though, I will take a look at it in an hour.

I just ran double check on Backup OTP code and seems like its incorrect, I'll restart it and see if it works then.

login normally with the official launcher once, my launcher executed everything successfully from my end earlier

@Person7557
Copy link
Author

Seems like it fails to enter OTP either way for me. Strange.

@Person7557
Copy link
Author

Person7557 commented Nov 8, 2023

Just managed to get the launcher to login me in on 1.1.3 version. the 1.1.5 opens the window form, that takes ~3 seconds to get the pop up to display the form for me, not sure if its normal/intended, but perhaps the OTP is entered before the forms move to right placement due to my latency from UK, either way, i would love to know where i can adjust the delay on some actions to make the launcher a bit faster at certain points and adjust it to eventual latency due to my WAN routing. As always, thank you for your work @jsoctocat

I just went back through 1.1.4 and it would not budge, while 1.1.3 spits out error when it attempts to check game version, but else than that, after few seconds delay, it launches the game without an issue.

@jsoctocat
Copy link
Owner

jsoctocat commented Nov 8, 2023

have you checked with the official launcher? the delay can be edited inside AuthenticationServiceProvider.cs, it should continue to wait for a response (up to 10seconds)

// wait for server response data
delayCounter = 1000;
do {
await Task.Delay(delayCounter);
delayCounter += 50;
} while (CustomResourceRequestHandler.ResponseData == null && delayCounter < 10000);

I will change the OTP to be generated from UTC time that gets fetched from worldtimeapi today

@jsoctocat
Copy link
Owner

I updated the launcher to input the OTP when the OTP appears rather than at the start of the launching process, let me know if the change fixes issue #20

@Person7557
Copy link
Author

I updated the launcher to input the OTP when the OTP appears rather than at the start of the launching process, let me know if the change fixes issue #20

Thank you, i will test it within an hour and let you know how it works.

@Person7557
Copy link
Author

It works nicely now. One suggestion would be to make an option to select visible or not visible form, as i prefered the lack of things popping up, would be great if you could let me know if i can just enable/disable that in one line of the code

@ManchiSoul
Copy link

I upgraded to lastest version and it works fine. only thing i want to mention is every time i press start game it shows the BrowserForm window then it disappear and start the game. i wish if this window are hidden like previous version

@jsoctocat
Copy link
Owner

In version 1.1.5 I changed CefSharp.OffScreen to CefSharp.WinForms so that a browserform opens up and shows the login process, the reason for the change was because there is a chance of running into this

ss

The launcher would get stuck waiting for the captcha to be completed before moving onto the next login step, therefore, I made the change.

I will check to see if it's possible to hide the window but most likely the solution would be automatically minimize the window at the start

@jsoctocat
Copy link
Owner

Release 1.1.6a will minimize the BrowserForm at the start

@Person7557
Copy link
Author

In version 1.1.5 I changed CefSharp.OffScreen to CefSharp.WinForms so that a browserform opens up and shows the login process, the reason for the change was because there is a chance of running into this

ss

The launcher would get stuck waiting for the captcha to be completed before moving onto the next login step, therefore, I made the change.

I will check to see if it's possible to hide the window but most likely the solution would be automatically minimize the window at the start

I've never once encountered this, that's why i did not see any point in that form to pop up for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants