Windows: Fix dynamic library build with Visual Studio #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that this is preventing me from statically linking the json-c library with Visual Studio. I was successfully using the json-c library and I am trying to update due to other changes but this seems to prevent me from doing that. |
|
I am sorry, I got it working now... I had some compiler settings wrong... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to compile json-c as a dynamic library with Visual Studio. This is needed because declaring a function as
externis not enough to make this compiler export it, so the resulting library was not exporting anything. I also export a couple functions which weren't before, as I was getting undefined references otherwise.As far as I know this should not break anything on other platforms but I didn't have time to confirm that.