Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable HAVE___THREAD #451

Closed
drizt opened this issue Oct 24, 2018 · 1 comment · Fixed by #617
Closed

Add option to disable HAVE___THREAD #451

drizt opened this issue Oct 24, 2018 · 1 comment · Fixed by #617

Comments

@drizt
Copy link
Contributor

drizt commented Oct 24, 2018

HAVE___THREAD produces libgcc_s_sjlj-1.dll extra dependencies with MinGW. It's not good. Please add a way to disable it.
besser82 added a commit to besser82/json-c that referenced this issue May 18, 2020
@besser82
Add an option to disable the use of thread-local storage.
871eb4a 
Using thread-local storage may not be desired in all environments
and/or use-cases, thus there should be an option to disable its use
on purpose.

Fixes json-c#451.
@besser82 besser82 mentioned this issue May 18, 2020
Merged
besser82 added a commit to besser82/json-c that referenced this issue May 18, 2020
@besser82
Add an option to disable the use of thread-local storage.
0d597b4 
Using thread-local storage may not be desired in all environments
and/or use-cases, thus there should be an option to disable its use
on purpose.

Fixes json-c#451.
@besser82
Copy link
Contributor

You may want to test the mentioned pull-request as a whole, since there is another commit included, that fixes the failing test_double_serializer, when building without thread-local storage.

besser82 added a commit to besser82/json-c that referenced this issue May 18, 2020
@besser82
CMake: Add an option to disable the use of thread-local storage.
78642dc 
Using thread-local storage may not be desired in all environments
and/or use-cases, thus there should be an option to disable its use
on purpose.

Fixes json-c#451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an option to disable the use of thread-local storage. besser82/json-c
2 participants
@drizt @besser82