Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec to disallow unknown keywords #1340

Closed
gregsdennis opened this issue Oct 26, 2022 · 5 comments · Fixed by #1512
Closed

Update spec to disallow unknown keywords #1340

gregsdennis opened this issue Oct 26, 2022 · 5 comments · Fixed by #1512

Comments

@gregsdennis
Copy link
Member

Following @handrews' discussion on disallowing non-vocab keywords, we decided that this is a feature that we want in order to help guarantee forward compability.

The spec needs to be updated accordingly.

@handrews
Copy link
Contributor

We did? I mean, I'm all for it! I just didn't realize there was consensus. There should probably be an ADR first as this is a pretty big deal, and there are some details to nail down.

@gregsdennis
Copy link
Member Author

As far as I could tell from the proposal, I felt that we all seemed to agree on doing it.

Others are, of course, encouraged to speak up.

@handrews
Copy link
Contributor

I can probably write it up as an ADR easily enough (the conversation wasn't that lengthy so I'll just do a bit of cut/paste/edit) and we can have an official PR for sign-off. If we're all in agreement it should go quickly anyway.

@jdesrosiers
Copy link
Member

There should probably be an ADR

The ADR I'm going to write will cover that we are committing to forward compatibility, but I don't think it will cover the specific changes (like this issue) that need to happen to make that possible. So, if you write an ADR specifically for this issue, I think there would be some overlap, but it could still make sense as a separate ADR.

@handrews
Copy link
Contributor

@jdesrosiers sounds good- I'm basically planning to just edit that discussion into a document. I don't plan on addressing the larger forwards compatibility topic, it would just be assumed from the SDLC and could link to the ADR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants