Fix the ordered list discrepancy on getting started page #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
reviewed
Apr 19, 2024
benjagm
approved these changes
Apr 22, 2024
Closed
notEthan
reviewed
Apr 23, 2024
| "description": "The price of the product", | ||
| "type": "number" | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Thanks for finding this @notEthan !!
@bhavukkalra can you create a new PR to fix this? I merged it too fast.
notEthan
reviewed
Apr 23, 2024
| ... | ||
| "dimensions": { | ||
| "type": "object", | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Thanks for finding this @notEthan !!
@bhavukkalra can you create a new PR to fix this? I merged it too fast.
notEthan
reviewed
Apr 23, 2024
| } | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Huge thanks for finding this!
Bhavuk can you create a new PR to fix this? I merged it too fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes the ordered list Discrepancy observed on the getting-started-step-by-step as reported in the issue #653
Issue Number:
Screenshots of fix
Summary
It was a markdown spacing issue. Found the fix here markdown-continue-numbered-list and applied.
Note- This might need to be applied to other pages as well which has this problem.Does this PR introduce a breaking change?
No
CC - @benjagm @gregsdennis @jviotti