Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill empty cells when write ets #111

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Fill empty cells when write ets #111

merged 3 commits into from
Jan 18, 2023

Conversation

Jindequan
Copy link

Fill empty cells when write ets.

Eliminate huge processing of fill_empty_cells/4 in each Xlslir.get_col/2.

Set empty cells by columns

Fix wrong result when executing get_col/2, see the "AA" in pictures below.

  1. If a cell is empty, the excel file won't save any info of it, so we cann't read it from the file. If we loss a cell, we cann't read correct result by get_col/2. Such as a col like this: [1, nil, nil, 1], it'll be get as [1, 1].
  2. So we fill every row with nil cells at the end.
  3. Cells quantity determined by the max length of all rows.

飞书20220419-215502
20220419-215546

@jsonkenl jsonkenl merged commit 0005f65 into jsonkenl:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants