Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing datetime convert code #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixing datetime convert code #117

wants to merge 5 commits into from

Commits on Mar 1, 2023

  1. Change test case to reflect actual xls content 

    Opening ./test/test_data/missing_styles.xlsx in libre office and
office365 shows '21.06.2019 02:39:12'

So testing against 02:39:11 was a mistake.

(now tests are broken)
    @jfburdet
    jfburdet committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f24c178 View commit details
    Browse the repository at this point in the history

  2. Adding a test case 

    This is the use case that made me discover the bug that
will be fixed in next commit.

0.395833333333333 should be interpreted as 9h30mn0s
but actual code interprets it as 9h29mn59s
    @jfburdet
    jfburdet committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    8cff4e9 View commit details
    Browse the repository at this point in the history

  3. Removing uneeded empty config.exs file

    @jfburdet
    jfburdet committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    a6afd45 View commit details
    Browse the repository at this point in the history

  4. Fixing datetime code

    @jfburdet
    jfburdet committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    fb35155 View commit details
    Browse the repository at this point in the history

  5. Adding format + 'mix format' 

    This commit has no functional changes, only applying
now standard 'mix format' command
    @jfburdet
    jfburdet committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    3dd40f5 View commit details
    Browse the repository at this point in the history