Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few updates #118

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

nathany-copia
Copy link

@nathany-copia nathany-copia commented Mar 14, 2023

Thanks for the library. Here are a few little cleanups and updates.

  • fix use Mix.Config deprecation, requires Elixir 1.9+
  • Update dependencies
  • Update Travis CI version to the last 2 versions switch to GitHub Actions with latest Erlang/Elixir
  • Add standard mix format config
  • Fix deprecation with single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead (I assumed these are all charlists -- please correct me if I'm wrong)
  • Include convert dest_path to chatlist when unzip #129 to fix Regression in Erlang OTP 27.1 #128 in Erlang 27.1

I refrained from committing all the mix format changes, as that can make review difficult, and you may want to tweak line-length or other settings beforehand.

@nathany-copia
Copy link
Author

Some more updates today

@nathany-copia
Copy link
Author

Still need a fix for #130 before Erlang 27.1 is fully supported.

@nathany-copia
Copy link
Author

With Erlang 27.1.1, everything is working well with this branch.

@vheathen
Copy link

vheathen commented Nov 7, 2024

@jsonkenl could you please have a look at the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in Erlang OTP 27.1
3 participants