feat: add test cases for handling empty arrays and non-array input in functions #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8
This PR adds test cases for handling empty arrays and non-array input in functions
sum
,prod
,min
,max
,average
,and
, andor
.Discussion points:
sum
on an empty array: throw or return0
?min
on an empty array: throw or returnnull
?max
on an empty array: throw or returnnull
?and
on an empty array: throw, returntrue
, or returnfalse
?or
on an empty array: throw or returnfalse
?Right now, this PR throws in all cases 1-6.
@lateapexearlyspeed I would love to hear your thoughts on these discussion points 😄.