Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd relaxed theme #52

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: readd relaxed theme #52

merged 2 commits into from
Dec 4, 2023

Conversation

ObserverOfTime
Copy link
Contributor

@ObserverOfTime ObserverOfTime commented Dec 4, 2023

It worked just fine before and elegant also uses fs so it shouldn't be an issue.

Summary by CodeRabbit

  • New Features
    • Introduced a new "relaxed" theme option for users to select when formatting their resumes.

Copy link

changeset-bot bot commented Dec 4, 2023

⚠️ No Changeset found

Latest commit: 2fd86d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 3:57pm
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 3:57pm

Copy link
Contributor

coderabbitai bot commented Dec 4, 2023

Walkthrough

A new theme named "relaxed" has been added to an existing collection of themes in a JavaScript object. This update extends the customization options for users by incorporating the "jsonresume-theme-relaxed" module into the THEMES object, which is likely used for rendering different styles of resumes.

Changes

File Path Change Summary
.../api/formatters/template.js Added "relaxed" theme to the THEMES export, importing it from "jsonresume-theme-relaxed".

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

vercel bot commented Dec 4, 2023

@ObserverOfTime is attempting to deploy a commit to the JSON Resume Team on Vercel.

A member of the Team first needs to authorize it.

@levino
Copy link
Collaborator

levino commented Dec 4, 2023

CI on master is broken. Waiting for #53 to fix that, then your PR should get merged immediately.

@levino levino added this pull request to the merge queue Dec 4, 2023
Merged via the queue into jsonresume:master with commit 92ab784 Dec 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants