Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge!] opinionated draft suggestion - for reference only #193

Closed
wants to merge 47 commits into from
Closed

[Do not merge!] opinionated draft suggestion - for reference only #193

wants to merge 47 commits into from

Conversation

stp-ip
Copy link
Member

@stp-ip stp-ip commented Sep 11, 2015

One proposed draft for the new spec as an overview.
I tried to integrate all discussions and suggestions from PRs, issues and the old spec.
Additionally I tried to abstract away a few specifics to make merging different sections/ideas easier.
I find that it's easier to discuss this as one document at least as an overview for now.
Please provide some feedback and if need be, we could split it out to various PRs afterwards. Especially as this PR is only changing the schema not yet the rest of the code.

Tasks where help is needed:

  • enum for publications.identifiers
  • enum for skills.level
  • enum for languages.level
  • mark required data and optional ones
  • verify the correct usage of additionalProperties on each section
  • should education.courses and education.exams be merged?
  • use bibJSON for publications

Include contact details for references and include testimonial in the
same section.
Added exam and course urls in addition to a better scoring system and a
new exam section.
Add date formats and consistent date descriptions.
Moving location to additional personal information and
make additional information section hideable via labels.
@stp-ip stp-ip mentioned this pull request Sep 11, 2015
@stp-ip
Copy link
Member Author

stp-ip commented Sep 11, 2015

"format": "uri"
},
"summary": {
"type": "string",
"description": "Write a short 2-3 sentence biography about yourself"
},
"location": {
"additionalInfo": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decide on the maximum default items to use and which to make optionally via extending.

@chrisdotcode
Copy link
Member

@stp-ip Ultimately, this PR is too big. While we can mark down changes we plan on making here, we're going to give each potential component of change it's own PR, working from #197, and cross-referencing which feature/bugfix that PR solves from the issue referenced.

"type": "object",
"$ref": "#/definitions/labels"
}
}
}
},
"awards": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global achievements instead of awards?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 achievements is more generic

@stp-ip
Copy link
Member Author

stp-ip commented Nov 17, 2015

Yeah I am just using this PR to have a better overview and mark discussion points to actual schema changes to have a reference point and to not forget things we discussed.
I agree that smaller PRs are the way to go, but a huge PR can give us the ability to look for how things could be merged or separated more easily as we have the whole picture.

@stp-ip stp-ip changed the title [WIP] 2015 draft suggestion [Do not merge!] opinionated draft suggestion Dec 24, 2015
@aloisdg
Copy link
Contributor

aloisdg commented Feb 21, 2016

"enom" should be "enum" in your original post

@stp-ip
Copy link
Member Author

stp-ip commented Feb 21, 2016

Thanks. Fixed.

@stp-ip stp-ip added the Idea label Dec 24, 2016
@stp-ip stp-ip changed the title [Do not merge!] opinionated draft suggestion [Do not merge!] opinionated draft suggestion - for reference only Dec 24, 2016
@stp-ip
Copy link
Member Author

stp-ip commented Jan 30, 2017

Will close this opinionated draft, as some of the ideas are already deprecated, merged or still being discussed.

@stp-ip stp-ip closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants