Support for PostGIS 3.2, 3.3 & 3.4 testing #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce testing for newer PostGIS versions.
One of the problems to solve was consistent, future-proof(-ish), testing across 5 different versions of PostGIS, as a test expectation might be valid for 3.0, 3.1 & 3.2, but changes in 3.3 and/or 3.4 due to the way PHPUnit handles
--group
and--exclude-group
, e.g. if a test is in 3.1 & 3.2, but you--exclude-group
on 3.1, then the 3.2 group membership is ignored.To work around this I added a small function to the generator that automatically add group membership to a catch-all
versioned
group, and for the highest-value group, any higher supported group values.Tests (e.g. PostgreSQL 13 & PostGIS 3.2) now can be run like so :
I haven't touched the CI yet, as you'll probably have feedback with respect to PHP & Postgres versions used in the matrix.
Happy to work with you to get things to your liking.