router.put Set by Index not ObjectID

[pehaada]

This is my first pull request my apologies if I'm doing something incorrect. I think there was an issue in

router.put(reGet, function (req, res, next) {

When the code was running for a subdocument that was an array of sub documents. It was trying to set

tobj.set(last, body); However last was an object ID and the Mongoose code would bomb out

MongooseArray.prototype.set = function set (i, val) {
this[i] = this._cast(val);
this._markModified(i);
return this;

I made a change that would search the subdocument and figure out the correct index based on the object ID passed in from the route.

[jspears]

Thanks for the pull request! I will take a look this weekend, I swear that
bit of code has bitten me like 20 different ways.

On Fri, Jun 13, 2014 at 1:34 PM, pehaada notifications@github.com wrote:

This is my first pull request my apologies if I'm doing something
incorrect. I think there was an issue in

router.put(reGet, function (req, res, next) {

When the code was running for a subdocument that was an array of sub
documents. It was trying to set

tobj.set(last, body); However last was an object ID and the Mongoose code

would bomb out

You can merge this Pull Request by running

git pull https://github.com/pehaada/mers master

Or view, comment on, or merge it at:

#32
Commit Summary

• Put Allow Arrays by index

File Changes

• M lib/routes.js
  https://github.com/jspears/mers/pull/32/files#diff-0 (31)

Patch Links:

• https://github.com/jspears/mers/pull/32.patch
• https://github.com/jspears/mers/pull/32.diff

—
Reply to this email directly or view it on GitHub
#32.

[jspears]

Hrm does npm test pass for you?
These are failing after the merge.
routes testing /rest/blogpost put comments[1] to the blogpost:
routes update a nested array put should update a nested array:

[pehaada]

I ended up reverting my change and pulling the latest code out of github. When I run the test on the github version I'm also seeing some of the test fail. Sorry for all the questions I'm new to using Mocha but learning a lot by running the tests :)

I assume on your current version the test are all passing?

On Commit 6afee24 I'm getting the following errors: