Avoid undefined values on StyleSheet #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only noticed this behavior on Android - but if for some reason, parser returns `undefined` values for an attribute (like a non-supported selector, such as `:after` and `:before`), React Native will throw an error inside `StyleSheet.create` saying `Object.freeze` can only be used with objects. On iOS, this error does not occur. Ideally this fix would make sure we never get `undefined` values at this point, but here's a quick fix that will avoid this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only noticed this behavior on Android - but if for some reason, parser returns
undefinedvalues for an attribute (like a non-supported selector, such as
:afterand:before), React Nativewill throw an error inside
StyleSheet.createsayingObject.freezecan only be used with objects. On iOS,this error does not occur.
Ideally this fix would make sure we never get
undefinedvalues at this point, but here's a quick fixthat will avoid this error.