Make enumerate
accept @Nullable Thread[]
(ditto ThreadGroup
).
#28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the method only writes to the array, it is fine with either a
nullable element type or a non-nullable element type. (I'm operating
under the usual assumption that tools treat arrays as covariant. For
purposes of Checker Framework users who set
-AinvariantArrays
, wecould consider using
@PolyNull
instead in eisop.)This change is prompted by a Kotlin caller that passes an array of
Thread?
because Kotlin won't allow an uninitialized array ofThread
.In Java, I would expect most users to allocate an uninitialized array of
[@NonNull] Thread
and pass that.(This is a pretty weird API, though, since it requires you to pass in an
array that you pre-size for the number of threads you expect and so you
might overshoot and end up (I assume; the docs are not clear) with nulls
in the result....)