Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test case for trial parameters with null values #3304

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jodeleeuw
Copy link
Member

This adds a test case for #3174. It checks to make sure that a plugin parameter with a non-null default value can still accept null as a specified value. This confirms that #3174 is fixed in version 8.0.

Closes #3174

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 5837568

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jodeleeuw jodeleeuw linked an issue Jun 3, 2024 that may be closed by this pull request
@jodeleeuw jodeleeuw merged commit 505be4b into v8 Jun 6, 2024
2 checks passed
@bjoluc bjoluc deleted the v8-null-default-test branch June 7, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indefinite recording not working in html-audio-response
2 participants