Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix g_mime_content_encoding_to_string return null for …DEFAULT value #94

Closed
wants to merge 1 commit into from
Closed

Fix g_mime_content_encoding_to_string return null for …DEFAULT value #94

wants to merge 1 commit into from

Conversation

mjog
Copy link
Contributor

@mjog mjog commented Mar 29, 2020

Its API docs say that GMIME_CONTENT_ENCODING_DEFAULT is a valid value,
but that is missed in the switch, resulting in null being returned
when that is passed in.

This also fixes expected behaviour for the Vala bindings, where a
string is returned for any valid enum value.

Its API docs say that GMIME_CONTENT_ENCODING_DEFAULT is a valid value,
but that is missed in the switch, resulting in null being returned
when that is passed in.

This also fixes expected behaviour for the Vala bindings, where a
string is returned for any valid enum value.
@jstedfast
Copy link
Owner

So the way this is meant to be handled is if NULL is returned, you just don't add a Content-Transfer-Encoding header. Otherwise the value returned should be set as the value. A value of "default" isn't helpful because there is no such encoding and no code in the wild exists that will check for it.

@jstedfast jstedfast closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants