Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migrate from istanbul to nyc #42

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix: Migrate from istanbul to nyc #42

merged 1 commit into from
Mar 26, 2020

Conversation

YasharF
Copy link
Contributor

@YasharF YasharF commented Jan 15, 2020

Per https://www.npmjs.com/package/istanbul the package has been deprecated.

This module is no longer maintained, try this instead: npm i nyc Visit https://istanbul.js.org/integrations for other alternatives.

This change will also fix the following warnings when running npm install

image
npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm WARN deprecated npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.

@YasharF YasharF changed the title Migrate from istanbul to nyc fix: Migrate from istanbul to nyc Jan 15, 2020
@YasharF
Copy link
Contributor Author

YasharF commented Jan 15, 2020

After merging this and other open PR's, can you also bump the package version and push the changes to the npm.com repo:

@RobLoach
Copy link
Member

Nice.

@RobLoach RobLoach self-requested a review March 26, 2020 19:36
Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Istanbul is referenced in the bin....

foreground(process.argv[0], [require.resolve('istanbul/lib/cli'), 'cover', __filename]);

@RobLoach RobLoach merged commit a0ffefe into jstransformers:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants