-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: CLI #52
Docs: CLI #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other things I think we could use:
- Some tips of looking for command output by tailing/grepping
logs/kernel.log
- A reference on the config we require
- Moving
docs/cli/cli.md
todocs/cli.md
(directory is redundant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of getting stuff merged, my comments can be addressed in a separate PR (especially given that CLI details will likely change within the next couple of weeks).
My only requirement before merging this would be adding this page to the config.mjs
file
$ >> exit | ||
``` | ||
|
||
::: tip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip feels unnecessary, given the tip at the start
|
||
::: tip | ||
|
||
- `jstz help`: Displays a general help message or help information for specific subcommands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephase this for the --help
flag
- `--self-address (-s) <SELF_ADDRESS>`: Address used when deploying the contract. | ||
|
||
- `--function-code (-f) <FUNCTION_CODE>`: The code for the function being deployed. | ||
|
||
- `--balance (-b) <BALANCE>`: Specifies the initial balance for the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types instead of names
### Example | ||
|
||
```bash | ||
$ export counter=tz4CYGgcFtphw3AXS2Mx2CMmfj6voV5mPc9b # Address of the previously deployed contract examples/counter.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary export
|
||
::: | ||
|
||
# Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be best to move the logs section to the top
Context
https://app.asana.com/0/1205170694555918/1205457666696805
Description
This PR an API reference and quick start for the URL runtime API
Manually testing the PR
npm run docs:dev