Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: CLI #52

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Docs: CLI #52

merged 3 commits into from
Oct 20, 2023

Conversation

alanmarkoTrilitech
Copy link
Collaborator

@alanmarkoTrilitech alanmarkoTrilitech commented Oct 13, 2023

Context

https://app.asana.com/0/1205170694555918/1205457666696805

Description

This PR an API reference and quick start for the URL runtime API

Manually testing the PR

npm run docs:dev

@sam-finch-tezos sam-finch-tezos added documentation Improvements or additions to documentation m9::documentation labels Oct 13, 2023
Copy link
Collaborator

@johnyob johnyob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other things I think we could use:

  • Some tips of looking for command output by tailing/grepping logs/kernel.log
  • A reference on the config we require
  • Moving docs/cli/cli.md to docs/cli.md (directory is redundant)

docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
docs/cli/cli.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@johnyob johnyob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of getting stuff merged, my comments can be addressed in a separate PR (especially given that CLI details will likely change within the next couple of weeks).

My only requirement before merging this would be adding this page to the config.mjs file

$ >> exit
```

::: tip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip feels unnecessary, given the tip at the start


::: tip

- `jstz help`: Displays a general help message or help information for specific subcommands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephase this for the --help flag

Comment on lines +126 to +130
- `--self-address (-s) <SELF_ADDRESS>`: Address used when deploying the contract.

- `--function-code (-f) <FUNCTION_CODE>`: The code for the function being deployed.

- `--balance (-b) <BALANCE>`: Specifies the initial balance for the function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types instead of names

### Example

```bash
$ export counter=tz4CYGgcFtphw3AXS2Mx2CMmfj6voV5mPc9b # Address of the previously deployed contract examples/counter.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary export


:::

# Logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be best to move the logs section to the top

@alanmarkoTrilitech alanmarkoTrilitech marked this pull request as ready for review October 20, 2023 13:16
@alanmarkoTrilitech alanmarkoTrilitech merged commit 19d3617 into main Oct 20, 2023
5 checks passed
@alanmarkoTrilitech alanmarkoTrilitech deleted the alan@docs/cli branch October 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation m9::documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants