-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls.Hosting(GTK): mappings for Frame #51
Conversation
…: adjust to compile with linux
… from Maui.Graphics.Gtk.dll)
….cs, GtkPlatformServices.cs & related stuff
…-main_init-linux-core_210521 Update to dotnet/maui/main und enhance
# Conflicts: # Microsoft.Maui.sln
…Interval, not Slider.Value
…rmatting [housekeeping] Automated PR to fix formatting errors
Core(Gtk): fixes in UI element styles
Core,Controls(Gtk): implement tap/click gestures
Core(Gtk): fix picker
Take VerticalOptions and HorizontalOptions of the layout into account when calculating layout on Gtk. This allows to customize placement of root element of the page. Before the root layout would behave as if both options were set to "Start". Co-authored-by: Parham <parhaamsaremi@gmail.com>
Core,Platform(GTK): fix some problems with Layouts
…rmatting [housekeeping] Automated PR to fix formatting errors
Remove generic catch phrase to avoid running into development problems in the future. For instance before [1] this catch phrase would catch NIE. The catch phrase should be removed so it doesn't swallow useful information. [1] jsuarezruiz@c876474
When visibility for image or label (or other views) was set to false, they stayed visible in the application.
Implement WidthRequest and HeightRequest mappings for Image.
Core(Gtk): fixes in images
Core: fix Label line break mode in Gtk
@webwarrior-ws can you rebase, to resolve the conflicts please? |
Add mappers for BorderColor and CornerRadius for Frame elements so they can now have borders.
Rebased. |
@jsuarezruiz Is there anything else that needs to be done here? |
@jsuarezruiz can you review please? I know we can always work with our fork but we prefer to use your repo as "upstream". |
@jsuarezruiz ping |
…: add mapping for CornerRadius, BorderColor (refactored from: jsuarezruiz#51)
i have seen ist, but i'm not happy with this solution. to my opinion this should be done in FrameHandler.Gtk (src/Controls/src/Core/Compatibility/Handlers/Gtk/FrameHandler.Gtk.cs) and done via Map / Update-Pattern i made a refactoring here: |
internal static void AddDefaultMappings() | ||
{ | ||
#if GTK | ||
ContentViewHandler.Mapper.AppendToMapping( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think will be better to manage and maintain to move this to FrameHandler.Gtk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is already done in lytico#289 and part of lytico/merge/main240321
Add mappers for BorderColor and CornerRadius for Frame elements so they can now have borders.