Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a LICENSE file #1

Closed
wants to merge 2 commits into from
Closed

Create a LICENSE file #1

wants to merge 2 commits into from

Conversation

Jacalz
Copy link

@Jacalz Jacalz commented Apr 27, 2023

Thanks for creating this project @jsummers. We ran into an issue over at fyne-io/fyne#3849 because our license check has flagged this repository as missing a license. I've added an MIT license to it.

@Jacalz
Copy link
Author

Jacalz commented May 26, 2023

Would you mind reviewing? @jsummers

@jsummers
Copy link
Owner

Acknowledged. I'll probably move the terms of use to its own file, though I probably won't name it "LICENSE".

@Jacalz
Copy link
Author

Jacalz commented Jun 14, 2023

Do you mean that you won't accept this PR? Using a LICENCE file is by far the most common way to do it on GitHub.

@jsummers
Copy link
Owner

I've mostly used COPYING or COPYING.txt in my projects. Maybe there's something wrong with that, but for now I prefer to be consistent.

@Jacalz
Copy link
Author

Jacalz commented Jun 14, 2023

That seems fine and it’s quite common as well. I have renamed the file to COPYING now. I hope that it feels better for you that way.

@Jacalz
Copy link
Author

Jacalz commented Jul 4, 2023

While I don't mean to offend you or be unkind in any way, I want to say that I would have preferred if this PR could have been handled better in accordance to good open source development practice. It would have been better if you requested changes on the PR and got it to a point where you were happy with it instead of committing your own preferred changes and ignoring my PR. You don't need to change anything but I just want to get it out there; I was trying to help.

@Jacalz Jacalz closed this Jul 4, 2023
@Jacalz Jacalz deleted the license branch August 4, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants