Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navbar.js #59

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Update navbar.js #59

merged 1 commit into from
Oct 18, 2022

Conversation

Ved142
Copy link
Contributor

@Ved142 Ved142 commented Oct 18, 2022

Added the functionality of redirecting to home on clicking nav logo.

PR Title

The purpose of this Pull Request is to fix #55

Description

This fix will ensure that whenever a user clicks on navbar logo he/she will be directed to the homepage.

How you solved

To Solve this problem I use Routers and onClick event. Whenever a person click on navbar logo, the onClick event will be fired and the user will be directed to home route.

Screenshots

Tailwind.Bootstrap.-.Personal.-.Microsoft_.Edge.2022-10-18.23-34-39.mp4

Checklist

  • I have Made this contribution as per the CONTRIBUTING guide in this repo
  • I have tested in local Environment.
  • I have made the fix as per issue converstaion
  • I have starred the repository ⭐

Added the functionality of redirecting to home on clicking nav logo.
@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tailwindcss-ui-components ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 6:09PM (UTC)

@jsvigneshkanna
Copy link
Owner

@Ved142
Great works, working as expected in preview deployment
Merging your changes

Also take a look on other issues like footer,new page creations too

@jsvigneshkanna jsvigneshkanna merged commit b0adb8c into jsvigneshkanna:master Oct 18, 2022
@Ved142
Copy link
Contributor Author

Ved142 commented Oct 21, 2022

Hey @jsvigneshkanna, please add hacktoberfest tag on my request so that it get accepted in Hacktoberfest 2022. Thanks 😄!!

@jsvigneshkanna
Copy link
Owner

@Ved142 , didnt it counted on hacktoberfest, did you checked your profile? What s the status now?

@Ved142
Copy link
Contributor Author

Ved142 commented Oct 21, 2022

Really sorry for disturbing you @jsvigneshkanna I just somehow missed it. I checked my profile and it's there. Sorry again..

@jsvigneshkanna
Copy link
Owner

No problem buddy @Ved142
It happens 😁
Btw, if you want to contribute more, please check for open issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nav logo not redirecting
2 participants