-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection errors aren't caught #19
Comments
Thanks for flagging! Do you have an example URL where that raises this error? |
Sure:
(Although I guess it may be a bit more non-deterministic, for instance when I plugged the same date into Web Archive manually, I got the archived page). |
Thanks, and indeed quite strange. I'm having an experience similar to yours: When I visit the archive page for that link, I sometimes get data, and other times an empty response. In terms of handling those errors, would you rather: (a) (b) retry up to (c) follow some other behavior? Also: @wumpus, any thoughts on what might be happening re. these Wayback Machine responses? |
The simplest option, IMO, would be to leave the decision to the user:
Rationale:
|
Many thanks to @Hunter-Github. Cf.: #19
First pass at handling this, here: #20 Adds Does this look/work as expected? Or were you thinking of another approach? |
Haven't tried the test yet, but the changes look sound to me - 9603712 |
Merged, incorporated into |
requests.exceptions.ChunkedEncodingError
is raised all too often.The text was updated successfully, but these errors were encountered: