Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add a few jsdoc type annotations to work around TS inference bugs for consumers #3695

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

bradzacher
Copy link
Contributor

Figured I'd split this out of #3694

This PR adds a few JSDoc type annotations to hint to TS what the types are. This helps work-around issues like typescript-eslint/typescript-eslint#8522 / microsoft/TypeScript#57460 where TS would infer the wrong type from the JS and would break strictly-typed config files.

@bradzacher bradzacher changed the title [Fix] add a few jsdoc type annotations to work around TS inference for consumers [Fix] add a few jsdoc type annotations to work around TS inference bugs for consumers Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (bd55ca2) to head (2124d13).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3695   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         133      133           
  Lines        9471     9471           
  Branches     3472     3472           
=======================================
  Hits         9259     9259           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

configs/all.js Show resolved Hide resolved
@ljharb ljharb force-pushed the add-minor-type-annotations branch from 85617a6 to 2124d13 Compare March 3, 2024 22:25
@ljharb ljharb merged commit 2124d13 into jsx-eslint:master Mar 3, 2024
309 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants