Make backoff MaxInterval and MaxElapsedTime configurable #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the max interval and max elapsed time configurabel for the exponential backoff used when getting a role based on source IP. The defaults are still the same e.g. 1 minute for MaxInterval and 15 minutes for the MaxElapsedTime. Fix jtblin#28
jtblin
reviewed
Dec 4, 2016
| @@ -49,6 +50,8 @@ func addFlags(s *cmd.Server, fs *pflag.FlagSet) { | |||
| fs.BoolVar(&s.AddIPTablesRule, "iptables", false, "Add iptables rule (also requires --host-ip)") | |||
| fs.StringVar(&s.HostInterface, "host-interface", "docker0", "Host interface for proxying AWS metadata") | |||
| fs.StringVar(&s.HostIP, "host-ip", s.HostIP, "IP address of host") | |||
| fs.DurationVar(&s.BackoffMaxInterval, "backoff-max-interval", backoff.DefaultMaxInterval, "Max interval for backoff when querying for role.") | |||
There was a problem hiding this comment.
I think I'd rather change the defaults to some saner values. We probably don't want to retry for more than a few seconds actually, what do you think?
There was a problem hiding this comment.
I think that makes sense. Updated to more sane defaults. Let me know what you think.
|
Thanks! |
|
Thanks, any chance you plan to cut a release with the latest changes? :) |
|
Yep gonna do this today real soon :) |
|
Awesome! |
|
Done, https://github.com/jtblin/kube2iam/releases/tag/0.3.0 and published image as well https://hub.docker.com/r/jtblin/kube2iam/tags/ |
mikkeloscar
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 5, 2016
Sets smaller timeout when getting role from Pod IP. jtblin/kube2iam#33
negz
pushed a commit
to negz/kube2iam
that referenced
this pull request
Feb 26, 2017
This makes the max interval and max elapsed time configurabe for the exponential backoff used when getting a role based on source IP. The defaults are still the same e.g. 1 minute for MaxInterval and 15 minutes for the MaxElapsedTime. Fix jtblin#28 * Use sane max interval & max elapsed time defaults
negz
pushed a commit
to negz/kube2iam
that referenced
this pull request
Feb 26, 2017
This makes the max interval and max elapsed time configurabe for the exponential backoff used when getting a role based on source IP. The defaults are still the same e.g. 1 minute for MaxInterval and 15 minutes for the MaxElapsedTime. Fix jtblin#28 * Use sane max interval & max elapsed time defaults
negz
pushed a commit
to negz/kube2iam
that referenced
this pull request
Feb 26, 2017
This makes the max interval and max elapsed time configurabe for the exponential backoff used when getting a role based on source IP. The defaults are still the same e.g. 1 minute for MaxInterval and 15 minutes for the MaxElapsedTime. Fix jtblin#28 * Use sane max interval & max elapsed time defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the max interval and max elapsed time configurabel for the
exponential backoff used when getting a role based on source IP.
The defaults are still the same e.g. 1 minute for MaxInterval and 15
minutes for the MaxElapsedTime.
Fix #28