parsing of the loss of lock indicator (lli) #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtec
reviewed
Oct 12, 2023
| @@ -141,7 +141,8 @@ def format_flat_rows(row): | |||
| columns=["observation_type"], | |||
| values="observation_value", | |||
| ).reset_index() | |||
| code_phase_columns = [c for c in per_sat.columns if c[0] == "C"] | |||
| # when using useindicator=True in georinex.load(), there are additional ssi columns such as C1Cssi. To exclude them, we check the length of the column name | |||
There was a problem hiding this comment.
I was just thinking - should we have an "Acronyms" section in README.md? For most of them we can just point people to RINEX 3.05 page 5. For those that are not in the RINEX list, we list them in the README. What do you think?
Opened a PR here: #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change, that requires to add the kwarg
useindicators=Truewhen callinggeorinex.load()Unfortunately, this requires more processing time.
Make sure to delete the pickle cache, by deleting files in 'afterburner/*'