Benchmark obs parsing + faster parser #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtec
commented
Jul 10, 2024
| @@ -1,7 +1,7 @@ | |||
| [tool.poetry] | |||
| name = "prx" | |||
| version = "0.0.1" | |||
| description = "Making GNSS positioning a bit more accessible" | |||
| description = "Making raw GNSS data more accessible" | |||
There was a problem hiding this comment.
Hmmm not sure this is an improvement ;)
jtec
commented
Jul 10, 2024
| @@ -215,15 +215,6 @@ def build_records( | |||
| check_assumptions(rinex_3_obs_file) | |||
| obs = helpers.parse_rinex_file(rinex_3_obs_file) | |||
|
|
|||
| # Flatten the xarray DataSet into a pandas DataFrame: | |||
|
@plutonheaven OK if I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses the current bottleneck of prx's speed, which is observation file parsing, by adding
Note that the PR adds the new parser, but does not enable it, so prx still uses georinex as its parsing backend.
What about the loss-of-lock indicator
The loss-of-lock indicators are not extracted yet, will deal with that in a follow-up PR.
What about nav files?
We can continue to rely on georinex's nav file parser, since parsing e.g. a 1-day file takes only about 45 seconds (M2 Mac), and most web-prx users will benefit from caching, since it is likely that a previous users has caused prx to download and parse the same nav files.
Testing
Running the benchmark yields
Note that the pandas-based parser's speed is pretty much independent of file size, at least in this benchmark.