Syntax change for Julia 1.5 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Ander -- thanks for putting in this PR! I haven't had time to update it for the new API, so really appreciate you putting in the work to bring the syntax up to date. As far as the static vector, yes, that sounds like it could potentially improve performance so would be worth giving a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
Thanks for making this great package public, I'm thinking of using it in some of my projects.
I've just gone through and updated the syntax for Julia 1.5. All of the examples and tests run perfectly.
What do you think about changing Coord to a static vector. Would it improve performance?
Something like:
Regards,
Ander