-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media models #12
Media models #12
Conversation
tydillon
commented
Sep 2, 2020
- Adds New and Replace media data models (still needs to be consolidated)
- A bit of a reorg, I separated clinicalsummary and media into two different modules for scalability
- Test updates
- Added tests against the models coming from redox
- Added tests to check the additionalProperties fn
- Wrote tests for new and replace media
- Added a big 'all test suite' that lets you run all of the tests at once (unsure if this is actually best practice or not, but just seemed logical...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have any questions
src/test/java/redox/clinicalsummary/patientpush/PatientPushTest_Myra.java
Outdated
Show resolved
Hide resolved
src/test/java/redox/clinicalsummary/patientpush/PatientPushTest_Sample.java
Outdated
Show resolved
Hide resolved
src/test/java/redox/clinicalsummary/patientquery/PatientQueryTest_Harley.java
Outdated
Show resolved
Hide resolved
src/test/java/redox/clinicalsummary/patientquery/PatientQueryTest_Sample.java
Outdated
Show resolved
Hide resolved
src/test/java/redox/clinicalsummary/patientqueryresponse/PatientQueryResponseTest_Sample.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #12 +/- ##
==============================================
- Coverage 62.53% 39.37% -23.16%
+ Complexity 565 532 -33
==============================================
Files 74 124 +50
Lines 1879 2900 +1021
Branches 1 1
==============================================
- Hits 1175 1142 -33
- Misses 704 1758 +1054
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅