Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media models #12

Merged
merged 6 commits into from
Sep 3, 2020
Merged

Media models #12

merged 6 commits into from
Sep 3, 2020

Conversation

tydillon
Copy link
Collaborator

@tydillon tydillon commented Sep 2, 2020

  • Adds New and Replace media data models (still needs to be consolidated)
  • A bit of a reorg, I separated clinicalsummary and media into two different modules for scalability
  • Test updates
    • Added tests against the models coming from redox
    • Added tests to check the additionalProperties fn
    • Wrote tests for new and replace media
    • Added a big 'all test suite' that lets you run all of the tests at once (unsure if this is actually best practice or not, but just seemed logical...)

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #12 into develop will decrease coverage by 23.15%.
The diff coverage is 3.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop      #12       +/-   ##
==============================================
- Coverage      62.53%   39.37%   -23.16%     
+ Complexity       565      532       -33     
==============================================
  Files             74      124       +50     
  Lines           1879     2900     +1021     
  Branches           1        1               
==============================================
- Hits            1175     1142       -33     
- Misses           704     1758     +1054     
Impacted Files Coverage Δ Complexity Δ
...model/clinicalsummary/common/AdvanceDirective.java 65.85% <ø> (ø) 12.00 <0.00> (?)
...edox/datamodel/clinicalsummary/common/Allergy.java 63.63% <ø> (ø) 10.00 <0.00> (?)
...edox/datamodel/clinicalsummary/common/AltCode.java 58.82% <ø> (ø) 5.00 <0.00> (?)
...redox/datamodel/clinicalsummary/common/Author.java 64.86% <ø> (ø) 11.00 <0.00> (?)
...dox/datamodel/clinicalsummary/common/Category.java 61.90% <ø> (ø) 6.00 <0.00> (?)
...x/datamodel/clinicalsummary/common/CodedValue.java 61.90% <ø> (ø) 6.00 <0.00> (?)
...edox/datamodel/clinicalsummary/common/Company.java 60.00% <ø> (ø) 6.00 <0.00> (?)
.../datamodel/clinicalsummary/common/Criticality.java 58.82% <ø> (ø) 5.00 <0.00> (?)
...ox/datamodel/clinicalsummary/common/Custodian.java 58.82% <ø> (ø) 5.00 <0.00> (?)
...datamodel/clinicalsummary/common/Demographics.java 64.44% <ø> (ø) 14.00 <0.00> (?)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7feb6cd...39faade. Read the comment docs.

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jtravan3 jtravan3 merged commit 34da702 into develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants