Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop td patientqueryresponse #7

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Conversation

tydillon
Copy link
Collaborator

Adds patientQueryResponse, improves tests for patientPush and patientQuery, consolidates some of the patientQueryResponse and patientPush files (looks like most overlap and will end up in common)

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #7 into develop will decrease coverage by 6.06%.
The diff coverage is 47.21%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop       #7      +/-   ##
=============================================
- Coverage      61.89%   55.83%   -6.07%     
- Complexity       697     1191     +494     
=============================================
  Files            107      198      +91     
  Lines           2380     4408    +2028     
=============================================
+ Hits            1473     2461     +988     
- Misses           907     1947    +1040     
Impacted Files Coverage Δ Complexity Δ
.../java/redox/datamodel/common/AdvanceDirective.java 65.85% <ø> (ø) 12.00 <0.00> (?)
src/main/java/redox/datamodel/common/Allergy.java 63.63% <ø> (ø) 10.00 <0.00> (?)
src/main/java/redox/datamodel/common/Author.java 64.86% <ø> (ø) 11.00 <0.00> (?)
src/main/java/redox/datamodel/common/Category.java 61.90% <ø> (ø) 6.00 <0.00> (?)
...c/main/java/redox/datamodel/common/CodedValue.java 61.90% <ø> (ø) 6.00 <0.00> (?)
src/main/java/redox/datamodel/common/Company.java 60.00% <ø> (ø) 6.00 <0.00> (?)
.../main/java/redox/datamodel/common/Criticality.java 58.82% <ø> (ø) 5.00 <0.00> (?)
...rc/main/java/redox/datamodel/common/Custodian.java 58.82% <ø> (ø) 5.00 <0.00> (?)
src/main/java/redox/datamodel/common/Diagnosi.java 61.90% <ø> (ø) 6.00 <0.00> (?)
src/main/java/redox/datamodel/common/Document.java 62.06% <ø> (ø) 9.00 <0.00> (?)
... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fd7d7...e2fd013. Read the comment docs.

@jtravan3 jtravan3 merged commit 8921e9f into develop Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants