Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating pateintpush files and moving to common folder #8

Merged
merged 6 commits into from
Sep 1, 2020

Conversation

tydillon
Copy link
Collaborator

@tydillon tydillon commented Sep 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #8 into develop will decrease coverage by 0.91%.
The diff coverage is 60.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop       #8      +/-   ##
=============================================
- Coverage      55.83%   54.91%   -0.92%     
+ Complexity      1191      993     -198     
=============================================
  Files            198      161      -37     
  Lines           4408     3735     -673     
=============================================
- Hits            2461     2051     -410     
+ Misses          1947     1684     -263     
Impacted Files Coverage Δ Complexity Δ
src/main/java/redox/datamodel/common/Address.java 60.86% <ø> (ø) 7.00 <0.00> (?)
.../java/redox/datamodel/common/AdvanceDirective.java 65.85% <ø> (ø) 12.00 <0.00> (ø)
src/main/java/redox/datamodel/common/Allergy.java 63.63% <ø> (ø) 10.00 <0.00> (ø)
src/main/java/redox/datamodel/common/AltCode.java 58.82% <ø> (ø) 5.00 <0.00> (?)
src/main/java/redox/datamodel/common/Author.java 64.86% <ø> (ø) 11.00 <0.00> (ø)
src/main/java/redox/datamodel/common/Company.java 60.00% <ø> (ø) 6.00 <0.00> (ø)
...rc/main/java/redox/datamodel/common/Custodian.java 58.82% <ø> (ø) 5.00 <0.00> (ø)
...main/java/redox/datamodel/common/Demographics.java 64.44% <ø> (ø) 14.00 <0.00> (?)
src/main/java/redox/datamodel/common/Document.java 62.06% <ø> (ø) 9.00 <0.00> (ø)
src/main/java/redox/datamodel/common/Dose.java 54.54% <ø> (ø) 3.00 <0.00> (?)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8921e9f...3abe555. Read the comment docs.

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Comment on lines 101 to 105
@JsonProperty("DateTime")
public void setDateTime(String dateTime) {
this.dateTime = dateTime;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have a setter for dateTime?

Comment on lines 111 to 115
@JsonProperty("DateTime")
public void setDateTime(String dateTime) {
this.dateTime = dateTime;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, here it is

@jtravan3 jtravan3 merged commit 1fedec5 into develop Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants