refactor(win): adjust default feature flags #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds win_sendinput_send_scancodes as a default feature. The feature has had some time to be tested and should be good enough to replace vkey output by default. With this change, anyone compiling the default kanata binary on Windows without knowing about the difference between vkey codes and scan codes and no awareness of winiov2 will hopefully have a better experience than they used to. The justfile line for compiling the legacy binary is adjusted as well so that it compiles without the now-default feature and continues to use vkey output, in case someone really needs it.
eugenesvk
pushed a commit
to eugenesvk/kanata
that referenced
this pull request
Sep 12, 2024
This commit adds win_sendinput_send_scancodes as a default feature. The feature has had some time to be tested and should be good enough to replace vkey output by default. With this change, anyone compiling the default kanata binary on Windows without knowing about the difference between vkey codes and scan codes and no awareness of winiov2 will hopefully have a better experience than they used to. The justfile line for compiling the legacy binary is adjusted as well so that it compiles without the now-default feature and continues to use vkey output, in case someone really needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds win_sendinput_send_scancodes as a default feature. The feature has had some time to be tested and should be good enough to replace vkey output by default. With this change, anyone compiling the default kanata binary on Windows without knowing about the difference between vkey codes and scan codes and no awareness of winiov2 will hopefully have a better experience than they used to.
The justfile line for compiling the legacy binary is adjusted as well so that it compiles without the now-default feature and continues to use vkey output, in case someone really needs it.