Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(win): map (no)convert scancodes #1166

Merged
merged 5 commits into from
Aug 4, 2024
Merged

feat(win): map (no)convert scancodes #1166

merged 5 commits into from
Aug 4, 2024

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented Jul 27, 2024

Describe your changes. Use imperative present tense.

Try adding code for previously-unmapped JIS keys. Not tested. #1160.

Checklist

  • Add documentation to docs/config.adoc
    • N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • N/A
  • Update error messages
    • N/A
  • Added tests, or did manual testing
    • Yes

@jtroo
Copy link
Owner Author

jtroo commented Jul 27, 2024

Likely need to add mappings here too for output:
https://github.com/jtroo/kanata/blob/a4fc5b8427eee5c2ace0bb16242950eed0d8e63f/src/oskbd/windows/interception_convert.rs

@jtroo jtroo mentioned this pull request Jul 27, 2024
Closed
@jtroo jtroo merged commit f51b8df into main Aug 4, 2024
4 checks passed
@jtroo jtroo deleted the jis branch August 4, 2024 04:34
eugenesvk pushed a commit to eugenesvk/kanata that referenced this pull request Sep 12, 2024
@jtroo @eugenesvk
feat(win): map (no)convert scancodes (jtroo#1166)
834d399 
Try adding code for previously-unmapped JIS keys. Not tested. jtroo#1160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtroo