Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: windows-interception-keyboard-hwids #723

Merged
merged 4 commits into from
Feb 9, 2024
Merged

feat: windows-interception-keyboard-hwids #723

merged 4 commits into from
Feb 9, 2024

Conversation

jtroo
Copy link
Owner

@jtroo jtroo commented Feb 7, 2024

Describe your changes. Use imperative present tense.

Add capability in Windows+Interception to specify keyboards to intercept and passthrough others.

Checklist

  • Add documentation to docs/config.adoc
    • Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes or N/A
  • Update error messages
    • Yes or N/A
  • Added tests, or did manual testing
    • Yes

@jtroo jtroo linked an issue Feb 7, 2024 that may be closed by this pull request
@CosmoDm
Copy link

CosmoDm commented Feb 7, 2024

I just compiled the code from the interceptonedev branch to try out the new windows-interception-keyboard-hwids functionality.
Unfortunately, kanata gives the same (null) hwid for all connected keyboards.
PS: hwid for mouse is ok.

@jtroo
Copy link
Owner Author

jtroo commented Feb 7, 2024

@CosmoDm

Are the keyboards plugged into a usb hub - which is then plugged into your computer? I've noticed that interception (and maybe Windows?) can't differentiate devices on the hub.

@CosmoDm
Copy link

CosmoDm commented Feb 7, 2024

@jtroo
No, not through the hub.

The keyboards are connected in different ways: one directly to the USB port with a cable, second one via 2.4GHz and the third via Bluetooth.

@jtroo
Copy link
Owner Author

jtroo commented Feb 8, 2024

@CosmoDm I think I found the issue, which is that the buffer was too small. I increased the buffer size, could you try again?

@CosmoDm
Copy link

CosmoDm commented Feb 8, 2024

@jtroo

With the increased buffer (512), the keyboards identified as device #4 and #8 were successfully detected. But device #6 did not.
I increased the HWID_ARR_SZ to 1024 and the hwid for device #6 was also detected.
I was wondering how much of a burden this increased buffer gives and tried to find the best option. In my case, HWID_ARR_SZ == 768 works for all three keyboards.

Nice project, by the way. Thank you!

@jtroo jtroo merged commit cdb782a into main Feb 9, 2024
4 checks passed
@jtroo jtroo deleted the interceptonedev branch February 10, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Limit to single keyboard
2 participants