Merge pull request oracle#139 in G/truffle from ~JAROSLAV.TULACH_ORACLE.COM/truffle:OneGarbageCheckPerSecond to master

woess · woess · commit 91254ff6b437 · 2016-07-12T10:49:40.000-07:00
* commit 'fe360adade17a5dcba14dc56b99decb7039df229':
  Limit the check for GCed Source objects to once per second to impact benchmarks that do many Source creations less
diff --git a/truffle/com.oracle.truffle.api/src/com/oracle/truffle/api/source/SourceImpl.java b/truffle/com.oracle.truffle.api/src/com/oracle/truffle/api/source/SourceImpl.java
@@ -49,8 +49,14 @@ protected SourceImpl clone() throws CloneNotSupportedException {
         return clone;
     }
 
+    private static long nextCheck;
+
     static synchronized void registerSource(SourceImpl source) {
-        findSource(null);
+        long now = System.currentTimeMillis();
+        if (nextCheck < now) {
+            findSource(null);
+            nextCheck = now + 1000;
+        }
         SOURCES = new Ref(source, SOURCES);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,14 @@ protected SourceImpl clone() throws CloneNotSupportedException {`
`49`	`49`	`return clone;`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ private static long nextCheck;`
	`53`	`+`
`52`	`54`	`static synchronized void registerSource(SourceImpl source) {`
`53`		`- findSource(null);`
	`55`	`+ long now = System.currentTimeMillis();`
	`56`	`+ if (nextCheck < now) {`
	`57`	`+ findSource(null);`
	`58`	`+ nextCheck = now + 1000;`
	`59`	`+ }`
`54`	`60`	`SOURCES = new Ref(source, SOURCES);`
`55`	`61`	`}`
`56`	`62`