Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.base62_encode returns empty string but it should return "0" #1

Closed
paz-zz opened this issue May 2, 2010 · 2 comments
Closed

0.base62_encode returns empty string but it should return "0" #1

paz-zz opened this issue May 2, 2010 · 2 comments

Comments

@paz-zz
Copy link

paz-zz commented May 2, 2010

0.base62_encode returns empty string but it should return "0"

@jtzemp
Copy link
Owner

jtzemp commented Jun 1, 2010

Hey, Paz.

Thanks for the message. I'm aware that this is an issue. I designed this library to be a component for a URL minification service. The base 62 number would be based off the index of the record. Since I don't start database indexes at 0, I was ok with this limitation.

I know it's not ideal, but until I get around to refactoring it, it'll likely have this issue. I'm very open to patches/forks/fixes if you're interested in making them. :)

Thanks,

JT

@jtzemp
Copy link
Owner

jtzemp commented Nov 25, 2010

Hey, Paz.

I know it's been a long time, but I've fixed this in version 0.1.4

Thanks!

nekodex pushed a commit to nekodex/base62 that referenced this issue Jan 18, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants