Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Implement junifer reset to delete job/results file. #240

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Feb 26, 2024

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Sometimes I make a mistake with one parameter in the YAML. Then I need to go and check where the storage file points to, delete the directory and then finally run junifer queue with --overwrite.

I would like this process to be part of junifer.

How do you imagine this integrated in junifer?

junifer reset /path/to/yaml

This should delete the storage directory and the job directory.

Although the reset argument must not necessary be that one.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@fraimondo fraimondo added enhancement New feature or request triage New issues waiting to be reviewed labels Jul 14, 2023
@synchon synchon removed the triage New issues waiting to be reviewed label Nov 7, 2023
@synchon synchon added this to the 0.0.5 (alpha 4) milestone Nov 7, 2023
Copy link

github-actions bot commented Feb 26, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-07 09:54 UTC

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.91%. Comparing base (9316bca) to head (464b8bf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   88.79%   88.91%   +0.12%     
==========================================
  Files         101      101              
  Lines        4506     4529      +23     
  Branches      860      864       +4     
==========================================
+ Hits         4001     4027      +26     
+ Misses        366      361       -5     
- Partials      139      141       +2     
Flag Coverage Δ
junifer 88.91% <78.26%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/api/cli.py 79.64% <100.00%> (+9.16%) ⬆️
junifer/pipeline/registry.py 100.00% <ø> (ø)
junifer/api/functions.py 94.20% <66.66%> (-2.16%) ⬇️

@synchon synchon merged commit 8668590 into main Mar 7, 2024
16 of 20 checks passed
@synchon synchon deleted the feat/junifer-reset branch March 7, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants