Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Support Brainnetome 246 parcellation #275

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Feb 23, 2024

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Request from @kaurao

How do you imagine this integrated in junifer?

Like other parcellations.

Do you have a sample code that implements this outside of junifer?

No.

Anything else to say?

No response

@synchon synchon added enhancement New feature or request parcellation Issues or pull requests related to parcellations (atlases) labels Nov 7, 2023
@synchon synchon added this to the 0.0.5 (alpha 4) milestone Nov 7, 2023
@synchon synchon self-assigned this Nov 7, 2023
Copy link

github-actions bot commented Feb 23, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-07 08:44 UTC

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (489a2a6) to head (f601fcf).

❗ Current head f601fcf differs from pull request most recent head 0b67db2. Consider uploading reports for the commit 0b67db2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         101      101           
  Lines        4506     4506           
  Branches      860      860           
=======================================
  Hits         4001     4001           
  Misses        366      366           
  Partials      139      139           
Files Coverage Δ
junifer/data/parcellations.py 87.39% <ø> (ø)

... and 1 file with indirect coverage changes

@synchon synchon force-pushed the feat/brainnetome-parcellation branch from 7229b3d to f601fcf Compare March 4, 2024 10:17
@synchon synchon force-pushed the feat/brainnetome-parcellation branch from f601fcf to 0b67db2 Compare March 7, 2024 07:45
@synchon synchon merged commit aad403d into main Mar 7, 2024
16 of 20 checks passed
@synchon synchon deleted the feat/brainnetome-parcellation branch March 7, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parcellation Issues or pull requests related to parcellations (atlases)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants