Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Change all probseg_ appearances with VBM_ for consistency #320

Merged
merged 6 commits into from
Apr 5, 2024
Merged

[FIX]: Change all probseg_ appearances with VBM_ for consistency #320

merged 6 commits into from
Apr 5, 2024

Conversation

fraimondo
Copy link
Contributor

@fraimondo fraimondo commented Apr 4, 2024 •
edited
Loading

  • fix issue with probseg_
  • description of feature: probseg_ is now replaced by VBM_
  • tests added/passed
  • add an entry for the latest changes

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0a2a95) to head (1d0bf5e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #320   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@fraimondo fraimondo changed the title Fix/probseg [FIX]: Change all probseg_ appearances with VBM_ for consistency Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-05 13:56 UTC

synchon
synchon requested changes Apr 5, 2024
View reviewed changes
docs/changes/newsfragments/320.change Outdated Show resolved Hide resolved
docs/changes/newsfragments/320.fix Outdated Show resolved Hide resolved
junifer/markers/parcel_aggregation.py Show resolved Hide resolved
junifer/markers/sphere_aggregation.py Show resolved Hide resolved
junifer/datagrabber/utils.py Show resolved Hide resolved
junifer/preprocess/warping/space_warper.py Show resolved Hide resolved
@fraimondo fraimondo requested a review from synchon April 5, 2024 09:41
@synchon synchon added enhancement New feature or request dataset Issues or pull requests related to datagrabbers or datasets labels Apr 5, 2024
@synchon synchon added this to the 0.0.4 (alpha 3) milestone Apr 5, 2024
@synchon synchon merged commit 3a36ad0 into main Apr 5, 2024
26 of 28 checks passed
@synchon synchon deleted the fix/probseg branch April 5, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synchon synchon synchon approved these changes

@LeSasse LeSasse Awaiting requested review from LeSasse

Assignees
No one assigned
Labels
dataset Issues or pull requests related to datagrabbers or datasets enhancement New feature or request
Projects
None yet
Milestone
0.0.4 (alpha 3)
Development

Successfully merging this pull request may close these issues.
2 participants
@fraimondo @synchon