[ENH]: Add scalar table storage support for HDF5FeatureStorage
#343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synchon
force-pushed
the
feat/scalar-table-storage-type
branch
from
38d6b6f
to
a9d5075
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
synchon
changed the title
HDF5FeatureStorage
synchon
added
storage
|
fraimondo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new storage type called
scalar_tablewhich is basically a table with scalar values. The data type is like a mix betweenmatrixwith user-definedrow_namesandrow_header_col_nameandtimeserieslike internal data storage i.e., non-uniform row and column count but fixed row count across elements. For now, storingeigenvaluesfromBrainPrint(#344) would use this and is only supported byHDF5FeatureStorage.