Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CAFOS pairs matching #67

Merged
merged 12 commits into from
Dec 28, 2023
Merged

Improve CAFOS pairs matching #67

merged 12 commits into from
Dec 28, 2023

Conversation

juanep97
Copy link
Owner

This improves astrometric calibration of CAFOS polarimetry images using the distance between pairs computed from already calibrated images.

The mean and std was computed by executing the following commands in the IOP4 IPython terminal:

In [1]: qs = ReducedFit.objects.filter(flags__has=ReducedFit.FLAGS.BUILT_REDUCED, instrument="CAFOS2.2").all()
In [2]: np.mean([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)
In [3]: np.std([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)

By using precomputed distances from already calibrated images, it increases the success rate for images with low number of stars where blind pair matching might fail.

@juanep97 juanep97 changed the title improve cafos pair finding Improve CAFOS pairs matching Dec 24, 2023
@morcuended
Copy link
Collaborator

The mean and std was computed by executing the following commands in the IOP4 IPython terminal:

In [1]: qs = ReducedFit.objects.filter(flags__has=ReducedFit.FLAGS.BUILT_REDUCED, instrument="CAFOS2.2").all()
In [2]: np.mean([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)
In [3]: np.std([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)

Do you think it is worth to keep this piece of information in the docs?

morcuended
morcuended previously approved these changes Dec 27, 2023
Copy link
Collaborator

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left some minor comments, but I think it can be merged.

iop4lib/instruments/instrument.py Show resolved Hide resolved
iop4lib/instruments/cafos.py Show resolved Hide resolved
iop4lib/instruments/cafos.py Show resolved Hide resolved
@juanep97
Copy link
Owner Author

juanep97 commented Dec 27, 2023

The mean and std was computed by executing the following commands in the IOP4 IPython terminal:

In [1]: qs = ReducedFit.objects.filter(flags__has=ReducedFit.FLAGS.BUILT_REDUCED, instrument="CAFOS2.2").all()
In [2]: np.mean([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)
In [3]: np.std([redf.astrometry_info[-1]['seg_disp_sign'] for redf in qs[len(qs)-300:len(qs)-1]], axis=0)

Do you think it is worth to keep this piece of information in the docs?

It will be one of the jupyter notebooks that I'm -slowly- writing for the docs. I included a comment in the meantime.

Copy link
Collaborator

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Go ahead with the merging.

@juanep97 juanep97 merged commit 65845a0 into main Dec 28, 2023
2 of 4 checks passed
@juanep97 juanep97 deleted the improve_caha_pairs branch December 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants