Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated windows client docs #1995

Closed
wants to merge 1 commit into from
Closed

Conversation

deto1986
Copy link

I have updated the windows client documentation, the current docs don't working anymore with the latest tailscale client. The new description is working fine and is less complex.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@aae42
Copy link

aae42 commented Aug 26, 2024

worked well for me... current instructions did not

@kradalby
Copy link
Collaborator

kradalby commented Sep 3, 2024

@nblock, this might be relevant to my comment on #2096.


You can set these using the Windows Registry Editor:
When the installation has finished, close the tailscale application in the windows tray. (Richt click > Exit)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a small typo "richt", probably use: … the windows tray: right click → Exit)

New-Item -Path "HKLM:\SOFTWARE\Tailscale IPN"
New-ItemProperty -Path 'HKLM:\Software\Tailscale IPN' -Name UnattendedMode -PropertyType String -Value always
New-ItemProperty -Path 'HKLM:\Software\Tailscale IPN' -Name LoginURL -PropertyType String -Value https://YOUR-HEADSCALE-URL
tailscale up --accept-routes --login-server https://<your-headscale-server>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other examples do not contain, --accept-routes. It should be removed for consistency reasons.


![windows-registry](./images/windows-registry.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kradalby suggested in #2096 (comment) to keep the registry instructions but probably degrade their need from "required" to "optional" and move into their own section.

If you remove them, you should also delete the screenshot: ./docs/images/windows-registry.png

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, based on the PR, it is implied that they dont work anymore, I dont think they have been removed, so not sure why that is.

Copy link
Collaborator

@nblock nblock Sep 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly looked into this and it seems that Tailscale changed the location of registries from HKLM:\SOFTWARE\Tailscale IPN to HKLM\Software\Policies around 2022, so the paths and the generated reg file are wrong. See tailscale/tailscale#3584 (comment) and Tailscale's Deploy Tailscale on Windows using MDM documentation.

Since our minimal client versions have fast user switching, we should follow Tailscale's recommendation to login: tailscale login --login-server=<url>.

The remaining issue is "unattended mode". It seemed to be a mess in the past, but now:


The simplest way to solve this seems to be:

  • Rewrite /windows to basically:
    • include a link to the Tailscale Windows download page
    • Print the login command
    • Minimal setup instructions
  • Cleanup the windows documentation accordingly and add a section about "unattended mode" which should advise the user to enable it via GUI. Probably also add the link to Deploy Tailscale on Windows using MDM as it contains the details about the registry keys.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, it might be a good time to remove /apple and /windows altogether? They provide little value with the newer Tailcale clients and there is also headscale's documentation at https://headscale.net which can be updated faster.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant at removing them, they feel useful, but can be as simple as possible. I find that it is slightly neater than the docs because the command can be generated with the correct url and copied as if.

Otherwise I agree with your other suggestions.

@kradalby
Copy link
Collaborator

kradalby commented Sep 5, 2024

@deto1986 are you able to have a look at the comments and test this? if not, maybe @nblock can continue it?

@deto1986
Copy link
Author

deto1986 commented Sep 9, 2024

Hi all, I was on vacation the last couple weeks. I will have a look into your feedback in the next days.

nblock added a commit to nblock/headscale that referenced this pull request Sep 9, 2024
* Simplify /windows to the bare minimum. Also remove the
  /windows/tailscale.reg endpoint as its generated file is no longer
  valid for current Tailscale versions.
* Update and simplify the windows documentation accordingly.
* Add a "Unattended mode" section to the troubleshooting section
  explaining how to enable "Unattended mode" in the via the Tailscale
  tray icon.

Tested on Windows 10, 22H2 with Tailscale 1.72.0

Replaces: juanfont#1995
See: juanfont#2096
@nblock nblock mentioned this pull request Sep 9, 2024
6 tasks
nblock added a commit to nblock/headscale that referenced this pull request Sep 9, 2024
* Simplify /windows to the bare minimum. Also remove the
  /windows/tailscale.reg endpoint as its generated file is no longer
  valid for current Tailscale versions.
* Update and simplify the windows documentation accordingly.
* Add a "Unattended mode" section to the troubleshooting section
  explaining how to enable "Unattended mode" in the via the Tailscale
  tray icon.
* Add infobox about /windows to the docs

Tested on Windows 10, 22H2 with Tailscale 1.72.0

Replaces: juanfont#1995
See: juanfont#2096
nblock added a commit to nblock/headscale that referenced this pull request Sep 9, 2024
* Simplify /windows to the bare minimum. Also remove the
  /windows/tailscale.reg endpoint as its generated file is no longer
  valid for current Tailscale versions.
* Update and simplify the windows documentation accordingly.
* Add a "Unattended mode" section to the troubleshooting section
  explaining how to enable "Unattended mode" in the via the Tailscale
  tray icon.
* Add infobox about /windows to the docs

Tested on Windows 10, 22H2 with Tailscale 1.72.0

Replaces: juanfont#1995
See: juanfont#2096
kradalby pushed a commit that referenced this pull request Sep 9, 2024
* Simplify /windows to the bare minimum. Also remove the
  /windows/tailscale.reg endpoint as its generated file is no longer
  valid for current Tailscale versions.
* Update and simplify the windows documentation accordingly.
* Add a "Unattended mode" section to the troubleshooting section
  explaining how to enable "Unattended mode" in the via the Tailscale
  tray icon.
* Add infobox about /windows to the docs

Tested on Windows 10, 22H2 with Tailscale 1.72.0

Replaces: #1995
See: #2096
@kradalby
Copy link
Collaborator

kradalby commented Sep 9, 2024

Thanks @deto1986, sorry for the abrupt close, very much appreciated the contribution and it helped mapping out what needed to be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants